Fix sitemap URLs when serving locally#40
Merged
brass75 merged 3 commits intorender-engine:mainfrom Mar 13, 2026
Merged
Conversation
brass75
requested changes
Mar 13, 2026
Removed override logic for site url Co-authored-by: Dan Shernicoff <dan@brassnet.biz>
Removed site update logic Co-authored-by: Dan Shernicoff <dan@brassnet.biz>
Paritoshcodes
commented
Mar 13, 2026
Contributor
Author
Paritoshcodes
left a comment
There was a problem hiding this comment.
Made the necessary changes in both the files.
brass75
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2596
When running
serve, the sitemap was generated using the configured site URL instead of the local server URL.This change overrides
SITE_URLwith the local server address when runningserve, ensuring that generated sitemap URLs correctly point tohttp://localhost:<port>during local development.