fix(svg): track inline styles for CSP#15933
Merged
Conversation
🦋 Changeset detectedLatest commit: 3ecf45e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Princesseuh
reviewed
Mar 16, 2026
packages/astro/src/assets/runtime.ts
Outdated
| const Component = createComponent({ | ||
| async factory(result: SSRResult, props: Record<string, any>) { | ||
| const normalizedProps = normalizeProps(attributes, props); | ||
| const svgContent = render`<svg${spreadAttributes(normalizedProps)}>${unescapeHTML(children)}</svg>`; |
Member
There was a problem hiding this comment.
won't this cause the styles to be twice in the page? Because the style tag will still be inside the SVG?
Member
Author
There was a problem hiding this comment.
True. I rebased the PR and it should be fixed now
08f8d5d to
3ecf45e
Compare
Merging this PR will improve performance by 10.19%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | Build: hybrid site (static + server) |
8.8 s | 8 s | +10.19% |
Comparing fix/csp-head-propagation (3ecf45e) with main (23d5244)
matthewp
approved these changes
Mar 16, 2026
Princesseuh
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Closes #15838
We now track the
styletags inside the SVG elements, and we pass them tocreateSvgComponent.If there are styles, we pass the propagation hint so that we can write styles in the end, and correctly generate and track CSP hashes.
Testing
Added a new test, existing tests should pass
Docs
N/A