perf(@astrojs/vercel): APFS clone for file copies + NFT dependency cache#15896
Open
nishantmodak wants to merge 1 commit intowithastro:mainfrom
Open
perf(@astrojs/vercel): APFS clone for file copies + NFT dependency cache#15896nishantmodak wants to merge 1 commit intowithastro:mainfrom
nishantmodak wants to merge 1 commit intowithastro:mainfrom
Conversation
On macOS, replace cpSync with cp -rc (APFS clonefile CoW) for the static output and _functions directory copies. Add a persistent cache for the NFT dependency trace (keyed by sha256 of package-lock.json) and a clone cache for the assembled func node_modules dir. All changes fall back gracefully to the existing cpSync path on non-macOS platforms or when cp is unavailable.
🦋 Changeset detectedLatest commit: 04ae8e3 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On macOS,
cp -rcusesclonefile(2)(APFS copy-on-write) which is ~3x faster thanNode.js
cpSyncfor large directories. This PR applies that optimization to threefile copy operations in the Vercel adapter, and adds a persistent cache for the NFT
dependency trace.
Changes
APFS clone for large file copies (
index.ts)dist/client/→.vercel/output/static/): wascpSync, nowcp -rcon macOSdist/server/→.vercel/output/_functions/): sameNFT dependency cache (
lib/nft.ts)node_modules/files traced by@vercel/nft, keyed bysha256(package-lock.json)nodeFileTraceentirely (saves ~1-2s)node_modules/dir using APFS CoW clonenode_modules/via clone (~50ms vs ~900ms) and clonesdist/server/into the bundleBenchmark (last9/last9.io — 273 pages, hybrid output)
_functions/file copy (warm)runHookBuildDonetotal (warm)All changes fall back gracefully on non-macOS platforms or when
cpis unavailable.Non-goals