feat: no longer accept the endpoint on the command line#1274
Open
feat: no longer accept the endpoint on the command line#1274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The endpoint on the command line always had to match
SRC_ENDPOINT, which defaults tohttps://sourcegraph.com; there was no point to supporting the command-line argument.This could be considered a "breaking change" because the error
The configured endpoint is [SRC_ENDPOINT], not [command-line-arg].Will no longer show up.It has been replaced by a usage error:
src login no longer accepts a URL argument; set SRC_ENDPOINT insteadBefore:
After:
Test plan
CI tests updated.