Include notification view in embedded workflow view#3618
Include notification view in embedded workflow view#3618TheodoreSpeaks merged 5 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview In embedded mode, notification
Written by Cursor Bugbot for commit c260487. This will update automatically on new commits. Configure here. |
Greptile SummaryThis PR fixes a bug where workflow validation errors were not visible in the embedded (mothership) workflow view by removing the Key changes:
Notes:
Confidence Score: 4/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[WorkflowContent renders] --> B{embedded?}
B -- No --> C[Render full UI\nToolbar, Panel, DiffControls,\nCommandList, OAuthModal]
B -- Yes --> D[Render minimal UI\nCanvas only]
C --> E[Notifications rendered]
D --> E
E --> F{visibleNotifications\nlength > 0?}
F -- No --> G[return null]
F -- Yes --> H[Render notification stack]
H --> I{notification has\naction?}
I -- No --> J[Show message + dismiss button]
I -- Yes --> K[Show action button]
K --> L{action type}
L -- copilot --> M{embedded?}
M -- No --> N[Open Panel → Copilot tab ✅]
M -- Yes --> O[Panel not mounted\nsilent no-op ⚠️]
L -- refresh --> P[window.location.reload]
L -- unlock-workflow --> Q[dispatchEvent]
Last reviewed commit: 44016ad |
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/workflow.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Summary
Workflow validation errors previously did not show up in logs due to the Notification view being not enabled for embedded mothership view. Removed the boolean check. Also switch tabs when running workflows from mothership
Type of Change
Testing
Validated that workflow runs with validation errors show error in mothership and in normal view
Checklist
Screenshots/Videos