Skip to content

Fix/skip approval#3616

Merged
TheodoreSpeaks merged 2 commits intostagingfrom
fix/skip-approval
Mar 17, 2026
Merged

Fix/skip approval#3616
TheodoreSpeaks merged 2 commits intostagingfrom
fix/skip-approval

Conversation

@TheodoreSpeaks
Copy link
Collaborator

Summary

After changing mothership to run workflows using interact true, confirmation is needed. This blocked all resources. Added a promptForToolApproval so it skipst his check for mothership.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Other: ___________

Testing

Tested that building resources works now.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Screenshots/Videos

Tools with requiresConfirmation (e.g. user_table) blocked indefinitely
in mothership because the frontend has no approval UI. Added a new
promptForToolApproval orchestrator option so mothership auto-executes
these tools while copilot continues to prompt for user approval.

Made-with: Cursor
@vercel
Copy link

vercel bot commented Mar 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Mar 17, 2026 0:37am

Request Review

@cursor
Copy link

cursor bot commented Mar 17, 2026

PR Summary

Medium Risk
Changes tool execution flow for requiresConfirmation tools in interactive mode; misconfiguration could either block workflows waiting for approval or auto-run tools without intended user confirmation.

Overview
Adds a new OrchestratorOptions.promptForToolApproval flag to control whether requiresConfirmation tools actually wait for client approval.

Updates SSE tool-call handling (including subagent tool calls) to only block on waitForToolDecision when this flag is enabled, and wires it per route: Copilot chat prompts for approval, while Mothership chat skips approval to avoid blocking resource/workflow runs.

Written by Cursor Bugbot for commit 8bfe39f. This will update automatically on new commits. Configure here.

@TheodoreSpeaks TheodoreSpeaks changed the base branch from main to staging March 17, 2026 00:33
Made-with: Cursor

# Conflicts:
#	apps/sim/app/api/mothership/chat/route.ts
@TheodoreSpeaks TheodoreSpeaks merged commit c090c82 into staging Mar 17, 2026
12 checks passed
@TheodoreSpeaks TheodoreSpeaks deleted the fix/skip-approval branch March 17, 2026 00:48
emir-karabeg pushed a commit that referenced this pull request Mar 17, 2026
…thership chat (#3616)

Tools with requiresConfirmation (e.g. user_table) blocked indefinitely
in mothership because the frontend has no approval UI. Added a new
promptForToolApproval orchestrator option so mothership auto-executes
these tools while copilot continues to prompt for user approval.

Made-with: Cursor

Co-authored-by: Theodore Li <theo@sim.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant