Builder configuration from some arguments failed

[llaville]

Q	A
PHPUnit version	All versions 10.5, 11.5, 12.5, 13.0
PHP version	8.4.17
Installation Method	Composer or PHAR

Summary

I've noticed that some PHPUnit options are not parsing/handling correctly. The first one that alert me is usage of --colors always

BTW, there is probably the same error with definition of long options --stop-on-failure and --coverage-text (see https://github.com/sebastianbergmann/phpunit/blob/main/src/TextUI/Configuration/Cli/Builder.php#L37)

Current behavior

phpunit-10.phar --colors always

PHPUnit 10.5.63 by Sebastian Bergmann and contributors.

Test file "always" not found

phpunit-11.phar --colors always

PHPUnit 11.5.53 by Sebastian Bergmann and contributors.

Test file "always" not found

phpunit-12.phar --colors always

PHPUnit 12.5.11 by Sebastian Bergmann and contributors.

Test file "always" not found

phpunit-13.phar --colors always

PHPUnit 13.0.2 by Sebastian Bergmann and contributors.

Test file "always" not found

How to reproduce

Compare each previous command to this one

phpunit-13.phar --colors=always

Note

When the equal sign is present, there is no issue

Expected behavior

For example ... at least an execution !

PHPUnit 13.0.2 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.4.17
Configuration: /shared/backups/bartlett/captainhook-bin-plugin/phpunit.xml.dist

No tests executed!

[sebastianbergmann]

The configuration for the --colors CLI option in PHPUnit\TextUI\CliArguments\Builder is (and has been for as long as I remember) colors==. This means that the = must be used and that --colors=always is valid, for example, while --colors always is not.

So the code works correct, but the documentation in the --help output is wrong:

❯ ./phpunit --help|grep colors
  --colors <flag>                      Use colors in output ("never", "auto" or "always")

The above should read --colors=<flag> instead.

The only CLI options that use == (and thus require the =) are colors, --coverage-text, and --stop-on-deprecation. I think the inconsistency between these three that use == all the others that use = should be cleaned up by only using =.