Revisit jar-dependencies and ruby-maven issue#211
Merged
headius merged 1 commit intoruby:masterfrom Mar 16, 2026
Merged
Conversation
ruby-maven is only used at build time to fetch a Maven install and use it as a tool to build the JRuby extension and jar file. If we have this as a direct development dependency when it is also being installed lazily by gems like psych (transitive dep of rdoc) there are issues with the installed ruby-maven getting overwritten mid- install by bundler. See ruby/rubygems#9386 This is an attempt to remove the ruby-maven dependency so it does not conflict with the bundling process and we can take a bit more time to figure out the long-term solution.
c9cad26 to
5d99d53
Compare
Contributor
Author
|
Relates to #126. The ruby-maven dependency does not appear to be necessary for the build to be green, so we're going to work around the bundler issue by removing it and I have reverted the upstream changes to jar-dependencies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ruby-maven is only used at build time to fetch a Maven install and use it as a tool to build the JRuby extension and jar file. If we have this as a direct development dependency when it is also being installed lazily by gems like psych (transitive dep of rdoc) there are issues with the installed ruby-maven getting overwritten mid- install by bundler.
See ruby/rubygems#9386
This is an attempt to remove the ruby-maven dependency so it does not conflict with the bundling process and we can take a bit more time to figure out the long-term solution.