gh-146041: Avoid lock in sys.intern() for already interned strings#146072
Open
colesbury wants to merge 1 commit intopython:mainfrom
Open
gh-146041: Avoid lock in sys.intern() for already interned strings#146072colesbury wants to merge 1 commit intopython:mainfrom
colesbury wants to merge 1 commit intopython:mainfrom
Conversation
Contributor
Author
|
@encukou, please let me know if you'd like me to do this differently. I've removed the assertion about unicode state in |
mpage
approved these changes
Mar 17, 2026
| PyObject *r; | ||
| int res = PyDict_GetItemRef(interned, s, &r); | ||
| if (res < 0) { | ||
| PyErr_Clear(); |
Contributor
There was a problem hiding this comment.
Clearing the error here feels a little weird to me, but it's consistent with the rest of the function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix free-threading scaling bottleneck in sys.intern and
PyObject_SetAttrby avoiding the interpreter-wide lock when the string is already interned and immortalized.sys.intern()#146041