fix: make password visibility toggle buttons accessible#3861
Merged
raclim merged 4 commits intoprocessing:developfrom Feb 20, 2026
Merged
fix: make password visibility toggle buttons accessible#3861raclim merged 4 commits intoprocessing:developfrom
raclim merged 4 commits intoprocessing:developfrom
Conversation
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
Contributor
Author
|
@raclim hey worked on the fix, pls let me know if any adjustments needed, Happy to. |
This was referenced Feb 15, 2026
Contributor
Author
|
Hey @raclim the new aria-label on the toggle button caused getByLabelText(/password/i) to match two elements. Anchored it to /^password$/i to target only the input. |
raclim
approved these changes
Feb 20, 2026
Collaborator
raclim
left a comment
There was a problem hiding this comment.
Thanks for fixing it so quickly! Just want to note that for future PRs, running through the checklist in the PR template before submitting can help catch these errors sooner!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3850
Changes
I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranchFixes #3850