Skip to content

fix: make password visibility toggle buttons accessible#3861

Merged
raclim merged 4 commits intoprocessing:developfrom
avinxshKD:fix/password-toggle-accessibility-3850
Feb 20, 2026
Merged

fix: make password visibility toggle buttons accessible#3861
raclim merged 4 commits intoprocessing:developfrom
avinxshKD:fix/password-toggle-accessibility-3850

Conversation

@avinxshKD
Copy link
Contributor

Fixes #3850

Changes

  • LoginForm: password visibility toggle now has accessible label that toggles between "Show password as plain text" and "Hide password"
  • SignupForm: both password and confirm password toggles now have accessible labels
  • Added translation keys for toggle button labels in en-US locale

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • has no typecheck errors (npm run typecheck)
  • is from a uniquely-named feature branch and is up to date with the develop branch
  • is descriptively named and links to an issue number, i.e. Fixes #3850
  • meets the standards outlined in the accessibility guidelines

@welcome
Copy link

welcome bot commented Feb 12, 2026

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@avinxshKD
Copy link
Contributor Author

avinxshKD commented Feb 12, 2026

@raclim hey worked on the fix, pls let me know if any adjustments needed, Happy to.

@avinxshKD
Copy link
Contributor Author

Hey @raclim the new aria-label on the toggle button caused getByLabelText(/password/i) to match two elements. Anchored it to /^password$/i to target only the input.

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it so quickly! Just want to note that for future PRs, running through the checklist in the PR template before submitting can help catch these errors sooner!

@raclim raclim merged commit c7d17ba into processing:develop Feb 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Password visibility toggle buttons are inaccessible to screen readers

2 participants