Improved pull request "Files Changed" experience feedback #163932
Replies: 2928 comments 1205 replies
-
|
I would like to be able to scroll through the Pull Request while the comment modal is open. Reason: When a comment is outdated, we need to look at the current version to check if it actually addresses the comment. I really love this feature! THANK YOU!!! |
Beta Was this translation helpful? Give feedback.
-
|
Update: I just found out that it appears when there's enough space (1280px width). Here's the updated feedback. I'd like to see the branch name in the sticky header at all times so that I can easily copy it when I'm reviewing a PR. I wrote the following before thoroughly experimenting. I'd like to see the branch name when the sticky header is shown (i.e., when you've scrolled to the bottom). The reason is that when I'm reviewing a long PR and want to checkout the branch to continue reviewing it locally, I have to go back all the way up to see or copy the branch name and then go back to where I left off. |
Beta Was this translation helpful? Give feedback.
-
|
I find the comment indicators in the sidebar really useful. It might also be useful to have them in the "diff file header." It's very useful when you've marked a file as "viewed" because you can see how many comments it has as you're scrolling without having to expand it. |
Beta Was this translation helpful? Give feedback.
-
This is really cool. Is it also possible to seamlessly toggle hiding white spaces? If that's achievable without doing a refresh would be amazing. |
Beta Was this translation helpful? Give feedback.
-
|
Clicking a line number always assumes you want to add a comment. In the previous experience it only changes the URL to have deep linking. |
Beta Was this translation helpful? Give feedback.
-
|
This is so much better, I might go back from reviewing with the VSCode extension now 🚀 I love the new alerts panel, unfortunately it looks like pressing Maybe we could have some grouping or clustering in the alerts panel in the future. |
Beta Was this translation helpful? Give feedback.
-
|
I would love to see the file tree sorted alphabetically with folders on top, then files. It is quite jarring to have changed files in the middle of folders when viewing the file tree currently. Example of current state Example of desired state This would mirror how the majority of developers view the code in their IDE |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Hi, I would like to play around with this, but I'm not seeing the opt-in mentioned in
Am I missing something? |
Beta Was this translation helpful? Give feedback.
-
|
The tab for |
Beta Was this translation helpful? Give feedback.
-
|
Not sure if this is the sort of feedback you're after, but the |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
On the Files changed tab I can only see 19 files out of 66. Why? |
Beta Was this translation helpful? Give feedback.
-
|
I used to be able to click on a useful link to see the submodule diff in PRs but now its just plain text. Could we have that back pls? |
Beta Was this translation helpful? Give feedback.
-
|
It doesn't always seem to remember if hide whitespace was turned on. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
This button is just noise
|
Beta Was this translation helpful? Give feedback.
-
|
The Chrome on Google Pixel 8a |
Beta Was this translation helpful? Give feedback.
-
|
my code reviews sometimes lose styling, check this gif for example sometimes when I try to edit an existing comment, it just loses all the styling |
Beta Was this translation helpful? Give feedback.
-
|
Doesn't jump into the diff. So useless!!!
|
Beta Was this translation helpful? Give feedback.
-
|
Hi @imanmahjoubi and team, I've been following this thread and testing the new Files Changed experience extensively. Here are my consolidated findings: Critical Issues (Blocking my workflow):
Accessibility concerns:
What I actually like:
Request: Can we get a timeline for fixing the pending comment bug? It's been reported multiple times in this thread. Also +1 to @serhii-surazhskyi-gl's point about showing more than 40 comments inline - this limit hurts large reviews. Thanks for the continuous updates! |
Beta Was this translation helpful? Give feedback.
-
|
Using Up and Down to scroll through lines of the diff makes sense…but right now that's also catching the native Cmd-Up event of "scroll to top of page". (Please don't implement that directly, just avoid swallowing Up and Down if there are modifiers set.) |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
There is a bug in the new view. When a file has only whitespace changes, the changes are not shown. Instead the text |
Beta Was this translation helpful? Give feedback.
-
Wrong HTML sanitationThere's a bug in rendering comments with HTML in them - HTML is removed, instead of being escaped (using 🟥 Due to some HTML sanitation, it's being viewed as (I checked the actual rendered HTML, it is ✅ Using inline code renders just fine: |
Beta Was this translation helpful? Give feedback.
-
|
My preference for Hide Whitespace is no longer being remembered. I now have to select the option from the upper-right menu for every PR. |
Beta Was this translation helpful? Give feedback.
-
|
nit: I am used to the CTRL+ENTER to confirm PR title changes, I see just Enter works, but could we get support for Enter and CTRL+Enter? |
Beta Was this translation helpful? Give feedback.
-
|
Please make file filters less hidden, shouldn't be hidden behind a sidepanel. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.


























Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
About the new experience
This updated experience focuses on performance, accessibility, and user productivity. Read more in the changelog.
Tip
If you are not already using the new experience, click the ✨Try the new experience in the upper-right corner of the classic "Files changed" page. You can easily switch back from the Preview menu.
✨ What's new
If you are coming from the classic experience, the new experience should feel familiar but adds some significant improvements:
✨ Updates
See what's been fixed and improved since the launch of the public preview:
🟡 Limitations
As of the initial public preview release, there are some temporary limitations that will be addressed over time:
While our previous experience had hard limits on large PRs, this new experience is being built to scale. That said, we’re increasing our limits incrementally. To start with, our additional current limitations are:
How you can help
Thanks for helping us build a better review experience—we read every comment!
Beta Was this translation helpful? Give feedback.
All reactions