chore: Swap Markdownlint for remark-lint#2580
Conversation
71e5f8d to
4a44f6a
Compare
da9d483 to
c44b515
Compare
|
I'm definitely in favor of this assuming nodejs/remark-preset-lint-node#21 lands, released and this PR makes the minimum possible overwrites. The more closer we are to the upstream rules there better. My main concern is the different markdown renderer we use here, but hopefully it won't cause any issues. |
403fc5a to
5d51daf
Compare
|
@nschonni are the current rules the minimum needed ones? Do we cover most of what we covered before? Also, I wonder, does remark-lint have a cache feature? |
|
I don't think this actually covers everything that Markdownlint does, but it has some more that it doesn't. A PR landed to added the "recommended" preset to the node baseline, but it needs a new release to include it. |
Would it be useful for me to publish a release at this time? |
|
Sure, maybe land the other minor dependency cleanup one first though. |
63d5c41 to
f01a3a1
Compare
|
For now, I've submitted a few PRs so some of the rules can be re-enabled |
Published. |
f01a3a1 to
fe4f9c4
Compare
|
Thanks, bumped the package and disabled newly failing rules |
|
Re: caching, I meant like stylelint or eslint has, so that consequent runs are faster. Maybe it doesn't have this feature, no big deal for now. So, to summarize:
That being said, this shouldn't block us from merging this. We can tackle the rules as we go. |
e855e52 to
f6e8cd9
Compare
package.json
Outdated
There was a problem hiding this comment.
Are we good to land this once we bump to 1.10.1?
There was a problem hiding this comment.
I think so, I've re-installed and rebased
The main node repo has styleguide defined in remark-preset-lint-node
f6e8cd9 to
71637a4
Compare
Re-opening #2460 because GitHub closed it on a force-push