doc: clarify dns.lookup callback signature when options.all is enabled#62274
Open
nthbotast wants to merge 2 commits intonodejs:mainfrom
Open
doc: clarify dns.lookup callback signature when options.all is enabled#62274nthbotast wants to merge 2 commits intonodejs:mainfrom
nthbotast wants to merge 2 commits intonodejs:mainfrom
Conversation
Signed-off-by: nthbotast <nathanaelbot@users.noreply.github.com>
Signed-off-by: Nathanael BOT <nathanaelbot@minidenathanael.home>
Collaborator
|
Review requested:
|
JakobJingleheimer
requested changes
Mar 16, 2026
Member
JakobJingleheimer
left a comment
There was a problem hiding this comment.
Unrelated changes to test-runner docs
Contributor
|
See also nodejs/undici#4869 (comment) from @Fdawgs
|
Contributor
|
The account itself also replied itself in fastify/fastify#6559 (comment)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dns.lookup()callback docs thataddressandfamilyare only passed whenoptions.allisfalseaddressescallback argument shape used whenoptions.allistrueFixes: #57355
Validation
git diff --check