doc: remove spawn with shell example from bat/cmd section#62243
Open
kovan wants to merge 2 commits intonodejs:mainfrom
Open
doc: remove spawn with shell example from bat/cmd section#62243kovan wants to merge 2 commits intonodejs:mainfrom
kovan wants to merge 2 commits intonodejs:mainfrom
Conversation
Remove the suggestion to use child_process.spawn() with the shell option set for running .bat and .cmd files on Windows. Passing arguments through spawn with shell: true is deprecated (DEP0190) due to shell injection risks. Keep the exec() and direct cmd.exe spawn alternatives. Fixes: nodejs#58735
aduh95
reviewed
Mar 14, 2026
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
reviewed
Mar 17, 2026
| terminal, and therefore cannot be launched using [`child_process.execFile()`][]. | ||
| When running on Windows, `.bat` and `.cmd` files can be invoked by: | ||
|
|
||
| * using [`child_process.spawn()`][] with the `shell` option set, or |
Contributor
There was a problem hiding this comment.
Can you add it back, along with the link to the deps:
* using [`child_process.spawn()`][] with the `shell` option set (not recommended, see [DEP0190][]), or
aduh95
reviewed
Mar 17, 2026
Comment on lines
+129
to
+131
| Using [`child_process.spawn()`][] with the `shell` option is not recommended | ||
| because passing arguments that way is deprecated ([DEP0190][]). | ||
|
|
Contributor
There was a problem hiding this comment.
I think this addition is kinda confusing as the shell option by itself is not deprecated – though I agree on the "not recommended" point, and removing it from the examples is fine. If you take my other suggestion, I think we can remove it
Suggested change
| Using [`child_process.spawn()`][] with the `shell` option is not recommended | |
| because passing arguments that way is deprecated ([DEP0190][]). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the suggestion to use
child_process.spawn()with theshelloption for running
.batand.cmdfiles on Windows. Passing argumentsthrough
spawnwithshell: trueis deprecated (DEP0190) due toshell injection risks. The
exec()and directcmd.exespawnalternatives remain documented.
Continues the work from #58739 which addressed the same issue but
stale-closed without review.
Fixes: #58735