build: add asan check in Github action#31902
build: add asan check in Github action#31902gengjiawen wants to merge 1 commit intonodejs:masterfrom
Conversation
|
Seems like a good idea but how long does |
https://github.com/nodejs/node/pull/31902/checks?check_run_id=460428978 took 1 hr 40mins. |
|
ASAN checks failed on first error (https://github.com/nodejs/node/runs/460428978?check_suite_focus=true), so I add |
|
@bnoordhuis @addaleax @richardlau Can you review this ? thanks. |
bnoordhuis
left a comment
There was a problem hiding this comment.
LGTM and thanks, this is useful!
To save everyone some clicking: it takes 205 minutes or about 3.5 hours for a full run. 1.5h is just the build itself though so maybe that can be sped up somehow.
PR-URL: #31902 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
Landed in 3ec4b21 |
PR-URL: #31902 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: #31902 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: #31902 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This related to #30257
This currently only runs on linux only. Acutally windows has made some progress on
this too, see https://devblogs.microsoft.com/cppblog/addresssanitizer-asan-for-windows-with-msvc/, but it require cmake as build toolchain IIUC. Also current code asan checks broken on macOS, so I didn't add them.
currrent Docker Image source: https://github.com/gengjiawen/node-build/blob/master/Dockerfile.
todo
Hopefully we can remove
continue-on-errorin the future.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes