build fails when --with-intl=small-icu with ICU 56.1

[drewfish]

When building node from source --with-intl=small-icu it looks like it's failing with rebuilding out/Release/libicuucx.a. I'm building using the following:

./configure --with-intl=small-icu --download=icu
make clean
make

Here's the log of the output: folta.txt

[drewfish]

Version v4.1.2 builds OK for me, but version v4.2.0 doesn't. Here's the result of git bisect:

$ git bisect start v4.2.0 v4.1.2
$ git bisect run ./go.sh
$ git bisect log
# bad: [6dc12b1042d5d4727f77e8a1c5758dab91400069] 2015-10-12, Version 4.2.0 'Argon' (LTS) Release
# good: [85df6ada477715020dbd22e2fb5e687d84d663ff] 2015-10-05, Version 4.1.2 (Stable) Release
git bisect start 'v4.2.0' 'v4.1.2'
# good: [365cf22cce79a8884b273eebf416de3b1531e50d] doc: update AUTHORS list
git bisect good 365cf22cce79a8884b273eebf416de3b1531e50d
# bad: [0cfc6d39caf94e10530bc55130f6fdf271055698] doc: recommend Infinity on emitter.setMaxListeners
git bisect bad 0cfc6d39caf94e10530bc55130f6fdf271055698
# good: [d4fc6d93ef1513bc7fca4d524e5de9c233d1f1ad] doc: add help repo link to CONTRIBUTING.md
git bisect good d4fc6d93ef1513bc7fca4d524e5de9c233d1f1ad
# good: [7c85557ef0ec9907e74f6a331d6694fea3fcd271] test: Fix test-fs-read-stream-fd-leak race cond
git bisect good 7c85557ef0ec9907e74f6a331d6694fea3fcd271
# bad: [2314378f0689394e0b0ad7417dc2d54c875b997c] src: fix u-a-free if uv returns err in ASYNC_CALL
git bisect bad 2314378f0689394e0b0ad7417dc2d54c875b997c
# bad: [af24376e187d444654787724b1cfc724137b0e85] build: Intl: deps: bump ICU to 56.1 (GA)
git bisect bad af24376e187d444654787724b1cfc724137b0e85
# first bad commit: [af24376e187d444654787724b1cfc724137b0e85] build: Intl: deps: bump ICU to 56.1 (GA)

The ./go.sh is those three lines mentioned in this issue description.

[MylesBorins]

@drewfish have you tried on v4.3.0?

/cc @nodejs/intl @jasnell @srl295

[drewfish]

Yeah, v4.3.0 failed the same way for me as well (as did today's master).

[drewfish]

I was able to get commit af24376 to build with the following line commented out:
https://github.com/nodejs/node/blob/af24376/Makefile#L72
I have no idea if that's a proper/sane fix. All tests passed, except test-net-connect-immediate-finish which I'm guessing is not related to intl.

[srl295]

./configure --with-intl=small-icu --download=icu
make clean
make

the make clean deletes the downloaded ICU as of #3281

[drewfish]

OK, trying make clean, configure, make now...

[drewfish]

Tag v4.2.0 works when I make clean before configure, so please close this issue as PEBCAC (Hmmm... PEBMT "problem exists between makefile targets".)
I'll be trying out the other instances where I saw failure (v5.0.0, master) but given that v4.2.0 worked I expect those to work as well.

[drewfish]

Yeah, v5.0.0 and master both build fine, so I think this issue is invalid.

[srl295]

Closing for now.

[drewfish]

Thanks! Sorry for the non-issue.