build: spaces in python path causes node_js2c build failure

[silverwind]

See #3984 (comment). I assume the user has installed Python under C:\Program Files\.

Also found http://stackoverflow.com/questions/17300638/building-node-js-v0-10-12-on-windows which points to node_js2c.vcxproj being generated with non-escaped paths. I think to correct way to handle this would be to quote the spaced path like C:\"Program Files"\.

@miklen you were able to fix this with reinstalling python to a non-space path, correct?

[bnoordhuis]

I think that may have been fixed in the gyp update in 1d65b99 from end of last month.

[miklen]

@silverwind yes, reinstalling to a non-spaced path fixed the problem.

[silverwind]

@miklen were you building off master?

Not sure if the linked commit really fixed this, but a possible workaround could be to remove this line, like it's done already for targets like specialize_node_d in the same file.

[miklen]

@silverwind yes.

[benjamingr]

Was this fixed in #4841 or the subsequent/related PRs? Can someone confirm this is still an issue?

[silverwind]

Yeah it was fixed by #4841, forgot to close.