meta: callback checking is inconsistent across lib

[MylesBorins]

Throughout the codebase there are two altering ways that callbacks are checked.

In some instances it is checked for truthyness

if (callback)
    process.nextTick(callback)

Where in others it is explicitly checked

if (typeof callback === 'function')
    process.nextTick(callback)

Hopefully this is not opening too large a bike shed, but I was curious if their is a legitimate benefit to using both.

[Fishrock123]

We should prefer the latter but there are some cases where that breaks odd things, iirc.

[cjihrig]

I was curious if their is a legitimate benefit to using both.

There is a legitimate reason to check for typeof === 'function'. Trying to call anything else will blow up.

[MylesBorins]

If that is the case would it not make sense to change all of the instances that do otherwise and mark it semver-major?

[cjihrig]

My opinion would be yes, but I'm not sure about the semver-major. I can't think of anything that could break from such a change (although I could easily be wrong).

[MylesBorins]

I'm not sure this is worth pursuing, going to close this for now.