test-buffer-indexof.js failing on pLinux BE

[mhdawson]

https://ci.nodejs.org/job/iojs+pr+ppc/nodes=ppcbe-fedora20/25/console

not ok 15 test-buffer-indexof.js
#
#assert.js:89
#  throw new assert.AssertionError({
#  ^
#AssertionError: 8 == -1
#    at Object. (/home/iojs/build/workspace/iojs+pr+ppc/nodes/ppcbe-fedora20/test/parallel/test-buffer-indexof.js:117:8)
#    at Module._compile (module.js:425:26)
#    at Object.Module._extensions..js (module.js:432:10)
#    at Module.load (module.js:356:32)
#    at Function.Module._load (module.js:311:12)
#    at Function.Module.runMain (module.js:457:10)
#    at startup (node.js:134:18)
#    at node.js:961:3

Looks like test was added or modified by this PR #2539

@skomski can you take a look ?

@jasnell FYI

[skomski]

@mhdawson Is it possible to get access to a big endian machine? string_search.h is mostly copied from v8 with some type changes and is tested on BE so most likely the problem is in IndexOfString in node_buffer.cc.

[mhdawson]

yes I can get you temporary access on the BE machine if you can send me your ssh public key

I sent the connection info to the email for your github account, once I get your ssh key I'll add and you'll be able to log in.

[jasnell]

So far I've only been able to investigate so far, but from what I can see, I believe the issue does lie in the node_buffer.cc IndexOfString changes that were introduced by #2539. I could be off but It appears that the input string argument on the buffer.indexOf is not being properly ordered properly on BE platforms so when the search is performed, it's not finding a match.