GitHub web UI: Force push timeline event

[vsemozhetbyt]

https://blog.github.com/changelog/2018-11-15-force-push-timeline-event/

Example: timeline event -> diff by force-pushed link

Does this mean that we need not anymore create fixup commits for nit changes in big-diff-PRs to alleviate follow-up reviews?

[devsnek]

it wasn't ever required to use fixup/squash commits.

also its worth mentioning that at some point in the recent future, github review comments started persisting between force pushes, so it is technically possible to do a pr where you handle the whole review with force pushes.

[vsemozhetbyt]

IIRC, I was asked to not force-push addressed comments in big diffs so that reviewers need not rescan all the diff to find what changed.

[refack]

Does this mean that we need not anymore create fixup commits for nit changes in big-diff-PRs to alleviate follow-up reviews?

Seems like this would solve that issue... Let's see how is the actual implementation affect our workflow.

also its worth mentioning that at some point in the recent future, github review comments started persisting between force pushes

Unless the code possession does not exist anymore (or does not fit some diff algorithm)

IIRC, I was asked to not force-push addressed comments in big diffs so that reviewers need not rescan all the diff to find what changed.

👍

[refack]

Another interesting feature - details view of the last commit in a "purple" merged PR.
AFAICT this is visible iff the last commit in the PR is identical to that pushed to the tree, and that commit has tests reported for it.

[Trott]

Feel free to re-open if there's something specific we need to resolve. Otherwise, it seems like this can be closed?