test: test-http(s)-set-timeout-server.js tests should be more similar

[mscdex]

• Version: all
• Platform: n/a
• Subsystem: test, http, https

Both of these tests contain unique changes that should copied to the other.

Examples:

• test-http-set-timeout-server.js has a secReceived check in serverResponseTimeoutWithPipeline() that was added to prevent flakiness, but this does not exist in the https counterpart.

• test-https-set-timeout-server.js utilizes common.mustCall(), common.mustNotCall(), etc., while the http counterpart still utilizes the old method of checking flags on exit of the process.

[jklepatch]

I would like to work on this :)

[gibfahn]

I would like to work on this :)

Let us know if you need any help.

[aqrln]

Copying @mscdex's comment from #13625 over here:

There are some other minor differences that could be made consistent, for example:

• server.listen() vs server.listen(0, )
• missing assert.ok(s instanceof http.OutgoingMessage);-type asserts in the https test file
• missing common.mustCall()s in the https test file (e.g. around server.listen() callback -- compared to http test file) and the http test file (e.g. around request handler callback -- compared to https test file)
• etc..

Really the only differences that should exist between the two should be the references to the http module vs the https module, use of net.connect() vs tls.connect(), and https.Server-specific stuff, like the passing of the cert, etc. configuration to https.createServer(). Everything else should be the same.