get-metadata: fail with a non-zero exit status

[ryzokuken]

Fixes: #130

@joyeecheung @cPhost Please take a look. I hope this is what was needed to be done.

[codecov]

Codecov Report

Merging #199 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #199   +/-   ##
=======================================
  Coverage   93.73%   93.73%           
=======================================
  Files          17       17           
  Lines         654      654           
=======================================
  Hits          613      613           
  Misses         41       41

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a992a24...f64c874. Read the comment docs.

[joyeecheung]

I think we can just let this throw here so it goes to the catch below, and replace process.exit(-1) below to process.exit(-1)? (I don't even know what I was thinking when I put -1 there :/)

[ryzokuken]

I think you mean process.exit(1)?

[joyeecheung]

Yes, like so

    .then(({status}) => {
      if (status === false) {
        throw new Error(`PR checks failed`);
      }
    })
    .catch((err) => {
      if (cli.spinner.enabled) {
        cli.spinner.fail();
      }
      cli.error(err);
      process.exit(1);
    });

[ryzokuken]

Cool. That was exactly what I had been thinking about.

[ryzokuken]

@joyeecheung take a look now.

[BridgeAR]

@ryzokuken thanks a lot!