chat: remove stale languageModelStats storage migration#301963
Open
xingsy97 wants to merge 1 commit intomicrosoft:mainfrom
Open
chat: remove stale languageModelStats storage migration#301963xingsy97 wants to merge 1 commit intomicrosoft:mainfrom
xingsy97 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a one-time application storage migration from LanguageModelStatsService that deleted legacy languageModelStats.* / languageModelAccess.* keys, and cleans up the now-unneeded IStorageService dependency.
Changes:
- Remove the storage key cleanup loop from
LanguageModelStatsService’s constructor. - Drop the
IStorageServiceconstructor injection and its import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix TODO in file src/vs/workbench/contrib/chat/common/languageModelStats.ts:"TODO: @sandy081 - remove this code after a while"
Remove the one-time storage key cleanup loop from the LanguageModelStatsService constructor. This migration code deleted legacy languageModelStats.* and languageModelAccess.* keys from application storage. The migration has been in place long enough for all users to have run it.
Also removes the now-unused IStorageService constructor dependency and its import.