fix(compiler): small improvement to error message handling#63255
Open
Vikash9546 wants to merge 1 commit intomicrosoft:mainfrom
Open
fix(compiler): small improvement to error message handling#63255Vikash9546 wants to merge 1 commit intomicrosoft:mainfrom
Vikash9546 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Made-with: Cursor
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects minor spelling/grammar in parser documentation/comments to reduce confusion when working around parseErrorForMissingSemicolonAfter, without changing compiler behavior.
Changes:
- Fix spelling in JSDoc (“mispelled” → “misspelled”).
- Fix grammar in an inline comment (“this some kind” → “this is some kind”).
You can also share your feedback on Copilot code review. Take the survey.
Contributor
|
From the Pull Request Template:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem exists
A small typo/grammar issue in
parseErrorForMissingSemicolonAfter's documentation can be a minor distraction when working on parser diagnostics.Why this change is useful
This PR corrects wording in two nearby comments in
src/compiler/parser.ts, making the intent clearer without changing any compiler behavior.Files modified
src/compiler/parser.tsTests
npm run build.npm testfails locally withEMFILE: too many open files, watchinunittests:: sys:: symlinkWatching::(environment/FS watcher limit); the change does not affect runtime or test logic.Made with Cursor