Skip to content

Expression Oversimplification#179

Draft
rcosta358 wants to merge 1 commit intomainfrom
expression-oversimplification
Draft

Expression Oversimplification#179
rcosta358 wants to merge 1 commit intomainfrom
expression-oversimplification

Conversation

@rcosta358
Copy link
Collaborator

@rcosta358 rcosta358 commented Mar 17, 2026

Would close #163. The simplification was too aggressive because it simplified expressions to their most simplified form, which sometimes was not helpful to see in the error message. To fix this, if an expression is simplified to a boolean literal, we use the unsimplified version and stop the simplification.

Example

Before

x > 5 && x == 1010 > 5true

After

x > 5 && x == 1010 > 5


This approach is too naive and is still not enough, as in some cases we still get e.g., true && true or x == true.

@rcosta358 rcosta358 self-assigned this Mar 17, 2026
@rcosta358 rcosta358 added enhancement New feature or request simplification Related to the simplification of expressions labels Mar 17, 2026
@rcosta358 rcosta358 marked this pull request as draft March 18, 2026 00:24
@rcosta358 rcosta358 marked this pull request as draft March 18, 2026 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request simplification Related to the simplification of expressions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't oversimplify to true

1 participant