Add test asserting that get_values works by itself#1
Closed
Codym48 wants to merge 1 commit intokfreezen:fix/get_valuesfrom
Codym48:fix/get_values
Closed
Add test asserting that get_values works by itself#1Codym48 wants to merge 1 commit intokfreezen:fix/get_valuesfrom Codym48:fix/get_values
Codym48 wants to merge 1 commit intokfreezen:fix/get_valuesfrom
Codym48:fix/get_values
Conversation
As described in gitpython-developers#1534, this test will fail in main with a KeyError about a missing section name even though the named sections do exist within the config file. This test will pass in the branch associated with gitpython-developers#1535. This test should keep the improved behavior healthy as the code evolves by preventing future developers from removing the eager loading of sections within get_values().
This was referenced Feb 16, 2023
|
@Codym48 Thanks a lot for your help! Are you able to post this PR against the respective PR in GitPython? If not, you can checkout the one this is going to be based on and create a new one in GitPython that contains both commits. That way we don't loose time waiting. |
Author
|
You're welcome! Sorry, I thought this is what you meant. Did you mean gitpython-developers#1555? |
|
Yes, that definitely works! Thanks again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in gitpython-developers#1534, this test will fail in main with a
KeyErrorabout a missing section name even though the named sections do exist within the config file.This test will pass in the branch associated with gitpython-developers#1535. This test should keep the improved behavior healthy as the code evolves by preventing future developers from removing the eager loading of sections within
get_values().