[MAJOR BUMP] Remove unsupported config var substitution#11690
Open
joshua-stauffer wants to merge 3 commits intodevelopfrom
Open
[MAJOR BUMP] Remove unsupported config var substitution#11690joshua-stauffer wants to merge 3 commits intodevelopfrom
joshua-stauffer wants to merge 3 commits intodevelopfrom
Conversation
✅ Deploy Preview for niobium-lead-7998 canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #11690 +/- ##
========================================
Coverage 84.57% 84.57%
========================================
Files 472 472
Lines 39157 39157
========================================
Hits 33117 33117
Misses 6040 6040 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an undocumented code path which allows using the syntax
$MY_SENSITIVE_VALUEfor defining sensitive values in config to be replaced at runtime. This is not a supported path, and can lead to credentials being accidentally logged in the case that a sensitive field (password etc) contains the character$, which triggers the substitution logic. This PR removes that unsupported path and updates the documentation for clarity.