Adding iterator method to Dict

[kellrott]

Addresses #58

[codecov-io]

Codecov Report

Merging #59 into master will increase coverage by 0.44%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   67.94%   68.38%   +0.44%     
==========================================
  Files          59       59              
  Lines       10378    10435      +57     
==========================================
+ Hits         7051     7136      +85     
+ Misses       2828     2794      -34     
- Partials      499      505       +6

Impacted Files	Coverage Δ
py/dict.go	63.21% <100%> (+8.55%)	⬆️
py/type.go	51.54% <0%> (+0.32%)	⬆️
py/string.go	88.2% <0%> (+2.88%)	⬆️
py/list.go	25.44% <0%> (+4.14%)	⬆️
py/sequence.go	52.68% <0%> (+18.27%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61059b4...a39291e. Read the comment docs.

[sbinet]

thanks for tackling this.

could you also add a test exercizing this new feature?
thanks!

[ncw]

According to the coverage report your test doesn't hit your added code?

https://codecov.io/gh/go-python/gpython/pull/59/diff

[kellrott]

The code is covered in py/tests/dict.py line 17, but the system doesn't seem to recognize that.

[ncw]

That is looking good! Can you just sharpen the test slightly and I'll merge - thanks :-)

[ncw]

Strictly speaking this test will no longer work when we implement the __contains__ method for dict.

Do can you change it to something like

l =  list(iter(a))
assert "a" in l
assert "c" in l
assert len(l) == 2

[kellrott]

This should be fixed now

[ncw]

That looks great now thank you! I see you added an items method too :-)

Will merge now.