Skip to content

🔄 chore: update schema URL to v0.57.2#1755

Merged
lpcox merged 1 commit intomainfrom
schema-update/v0.57.2-32df32b2f4fe0492
Mar 11, 2026
Merged

🔄 chore: update schema URL to v0.57.2#1755
lpcox merged 1 commit intomainfrom
schema-update/v0.57.2-32df32b2f4fe0492

Conversation

@github-actions
Copy link
Contributor

Schema URL Update

Updates the MCP Gateway JSON schema validation URL from v0.57.0 to v0.57.2.

Files Changed

  • internal/config/validation_schema.goschemaURL variable updated to v0.57.2
  • internal/config/rules/rules.goSchemaURL constant updated to v0.57.2
  • internal/config/validation_schema_test.go — hardcoded schema URLs updated to v0.57.2

Why

Pinning to a specific release tag ensures reproducible, deterministic configuration validation — the schema won't silently change between runs.

Release Notes

See the gh-aw release notes for changes in this schema version.

Generated by Nightly Schema Updater ·

Warning

⚠️ Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • invalidhostthatdoesnotexist12345.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "invalidhostthatdoesnotexist12345.com"

See Network Configuration for more information.

  • expires on Mar 17, 2026, 10:11 PM UTC

Pin mcp-gateway-config.schema.json to the latest gh-aw release tag
(v0.57.2) for reproducible, deterministic configuration validation.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@lpcox lpcox marked this pull request as ready for review March 11, 2026 21:08
Copilot AI review requested due to automatic review settings March 11, 2026 21:08
@lpcox lpcox merged commit 5070b83 into main Mar 11, 2026
3 checks passed
@lpcox lpcox deleted the schema-update/v0.57.2-32df32b2f4fe0492 branch March 11, 2026 21:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the pinned MCP Gateway JSON Schema URL from gh-aw release v0.57.0 to v0.57.2 across validation code and tests to keep config validation deterministic and in sync with the referenced schema release.

Changes:

  • Bump the schema fetch URL used by config JSON schema validation to v0.57.2.
  • Update the schema documentation link surfaced in validation error messages to v0.57.2.
  • Update the test expectation for the schema URL in enhanced error messages to v0.57.2.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
internal/config/validation_schema.go Updates the schema fetch URL used during JSON schema compilation/validation.
internal/config/rules/rules.go Updates the schema reference URL included in validation error footers.
internal/config/validation_schema_test.go Updates test expectations to match the new pinned schema URL.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment on lines 40 to +44
//
// Current schema version: v0.50.7
//
// Alternative: Embed the schema using go:embed directive for zero network dependency.
schemaURL = "https://v-raw-githubusercontent-com.adclosenn.dev/github/gh-aw/v0.57.0/docs/public/schemas/mcp-gateway-config.schema.json"
schemaURL = "https://v-raw-githubusercontent-com.adclosenn.dev/github/gh-aw/v0.57.2/docs/public/schemas/mcp-gateway-config.schema.json"
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The schema pinning comment block is now inconsistent with the actual pinned URL: it still says the schema is fetched from the main branch and lists "Current schema version: v0.50.7". Update this documentation to reflect the pinned version (v0.57.2) and the actual fetch behavior so future updates follow the documented steps correctly.

See below for a potential fix:

	// The schema is fetched from a specific tagged release of gh-aw (a pinned version),
	// not from the main branch. This ensures stable and reproducible validation behavior.
	//
	// To update to a new pinned version:
	//   1. Check the latest gh-aw release: https://github.com/github/gh-aw/releases
	//   2. Update the version tag in the URL below (e.g., vX.Y.Z)
	//   3. Run tests to ensure compatibility: make test
	//   4. Update this comment with the matching version number
	//
	// Current schema version: v0.57.2

Copilot uses AI. Check for mistakes.
//
// Alternative: Embed the schema using go:embed directive for zero network dependency.
schemaURL = "https://v-raw-githubusercontent-com.adclosenn.dev/github/gh-aw/v0.57.0/docs/public/schemas/mcp-gateway-config.schema.json"
schemaURL = "https://v-raw-githubusercontent-com.adclosenn.dev/github/gh-aw/v0.57.2/docs/public/schemas/mcp-gateway-config.schema.json"
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The schema URL is duplicated here and in internal/config/rules/rules.go (rules.SchemaURL). To avoid future drift (e.g., error footer linking to a different version than the validator fetches), consider sourcing both from a single constant (for example, have config use rules.SchemaURL or move the URL to a shared constant).

See below for a potential fix:

	//   2. Update the schema URL in rules.SchemaURL to use a version tag instead of main
	//   3. Run tests to ensure compatibility: make test
	//   4. Update related documentation with the version number
	//
	// Current schema version: see rules.SchemaURL
	//
	// Alternative: Embed the schema using go:embed directive for zero network dependency.
	schemaURL = rules.SchemaURL

Copilot uses AI. Check for mistakes.
Comment on lines 13 to 16
const (
ConfigSpecURL = "https://github.com/github/gh-aw/blob/main/docs/src/content/docs/reference/mcp-gateway.md"
SchemaURL = "https://v-raw-githubusercontent-com.adclosenn.dev/github/gh-aw/v0.57.0/docs/public/schemas/mcp-gateway-config.schema.json"
SchemaURL = "https://v-raw-githubusercontent-com.adclosenn.dev/github/gh-aw/v0.57.2/docs/public/schemas/mcp-gateway-config.schema.json"
)
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SchemaURL is duplicated with config's schemaURL in internal/config/validation_schema.go. Consider centralizing the schema URL in one place so the validation error footer and the schema fetch logic cannot accidentally get out of sync on future bumps.

Copilot uses AI. Check for mistakes.
Comment on lines 556 to 560
"Location:",
"Error:",
"Details:",
"https://v-raw-githubusercontent-com.adclosenn.dev/github/gh-aw/v0.57.0/docs/public/schemas/mcp-gateway-config.schema.json",
"https://v-raw-githubusercontent-com.adclosenn.dev/github/gh-aw/v0.57.2/docs/public/schemas/mcp-gateway-config.schema.json",
},
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test hardcodes the schema URL string. Since the URL is also defined as rules.SchemaURL (used in the error footer), consider referencing that constant here to avoid needing to update tests separately on every schema bump.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants