Import INT50-CPP into 4-1-3#1088
Open
MichaelRFairhurst wants to merge 1 commit intomichaelrfairhurst/package-undefined-behaviorfrom
Open
Import INT50-CPP into 4-1-3#1088MichaelRFairhurst wants to merge 1 commit intomichaelrfairhurst/package-undefined-behaviorfrom
MichaelRFairhurst wants to merge 1 commit intomichaelrfairhurst/package-undefined-behaviorfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the CERT INT50-CPP “out-of-range enum cast” rule into a reusable shared CodeQL library and reuses it to introduce a new MISRA C++ RULE-4-1-3 query for critical unspecified behavior.
Changes:
- Extracted INT50-CPP query logic into a new shared module
DoNotCastToAnOutOfRangeEnumerationValueShared.qlland updated the CERT query to use it. - Added a new MISRA wrapper query
OutOfRangeEnumCastCriticalUnspecifiedBehavior.qland registered it in the Undefined package metadata/exclusions. - Added shared tests in
cpp/common/test/...and hooked both CERT and MISRA tests to them via.testref.
Reviewed changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| rule_packages/cpp/Undefined.json | Registers the new MISRA RULE-4-1-3 query in the Undefined package metadata. |
| rule_packages/cpp/TypeRanges.json | Adds shared_implementation_short_name for INT50-CPP to reflect the shared implementation. |
| cpp/misra/test/rules/RULE-4-1-3/OutOfRangeEnumCastCriticalUnspecifiedBehavior.testref | Points MISRA tests to the shared common test query. |
| cpp/misra/src/rules/RULE-4-1-3/OutOfRangeEnumCastCriticalUnspecifiedBehavior.ql | New MISRA query wrapper using the shared implementation. |
| cpp/common/test/rules/donotcasttoanoutofrangeenumerationvalueshared/test.cpp | New shared test cases (COMPLIANT/NON_COMPLIANT coverage). |
| cpp/common/test/rules/donotcasttoanoutofrangeenumerationvalueshared/DoNotCastToAnOutOfRangeEnumerationValueShared.ql | Test query instantiating the shared module for the common test harness. |
| cpp/common/test/rules/donotcasttoanoutofrangeenumerationvalueshared/DoNotCastToAnOutOfRangeEnumerationValueShared.expected | Expected results for the shared test query. |
| cpp/common/src/codingstandards/cpp/rules/donotcasttoanoutofrangeenumerationvalueshared/DoNotCastToAnOutOfRangeEnumerationValueShared.qll | New shared library module implementing the out-of-range enum cast detection. |
| cpp/common/src/codingstandards/cpp/exclusions/cpp/Undefined.qll | Registers the new query in Undefined query metadata/types. |
| cpp/cert/test/rules/INT50-CPP/DoNotCastToAnOutOfRangeEnumerationValue.testref | Points CERT tests to the shared common test query. |
| cpp/cert/src/rules/INT50-CPP/DoNotCastToAnOutOfRangeEnumerationValue.ql | Refactored to import/instantiate the shared module. |
| change_notes/2026-03-17-share-out-of-range-enum-cast-query.md | Change note documenting the refactor/reuse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
please enter the description of your change here
Change request type
.ql,.qll,.qlsor unit tests)Rules with added or modified queries
RULE-4-1-3Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Reviewer
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.