Add failing test for default-valued properties#297
Conversation
@attrable properties with a default value specified using a getter method incorrectly have their setter method called with an empty string. This incorrect behaviour does not happen if: - the property is in the html definition - the property does not have a default value supplied by a getter method
|
👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.
|
Contributor
|
Thanks for filing this @ryecroft. I'll be looking into this soon hopefully! |
Contributor
|
I'm going to merge this as I don't want the contribution to go unnoticed, but I don't think we'll get round to fixing this any time soon. Sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@attr properties with a default value (specified using a getter method) incorrectly have their setter method called with an empty string after setting the property in the connectedCallback
This incorrect behaviour does not happen if:
<initialize-attr-test has-foo='' />