This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Conversation
When returning a container it should report all steps complete.
When a repository is opened rather than cloned, the operation won't have reported any progress. As a workaround, report 1/1 steps complete before returning a CodeContainer.
15 tasks
StanleyGoldman
approved these changes
Feb 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the
Get to Codeflow callsAcquireCodeContainerAsync, it usesdownloadProgresscompletion as a signal to close the dialog. This PR ensures that this signal is sent when opening a repository as well as cloning a repository.What this PR does
GitHub.StartPageproject /GitHubContainerProviderclassdownloadProgressas complete beforeAcquireCodeContainerAsyncreturns aCodeContainerIt uses the following call to signal completion (1 of 1 steps complete with no progress message):
How to test
Get to Code+GitHubintegrationTools > Dogfoodand select .vsix artifact (or URL) for this PR + restart VSClone or checkout codeGitHubbutton underBrowse a repositoryOpenbuttonClone or checkout codewindow to closeTeam Explorertool windowFixes #2211