Draft
Conversation
Keats
reviewed
May 9, 2024
Collaborator
Keats
left a comment
There was a problem hiding this comment.
sorry for the late review :(
It would be nice to revert the list change so it's easier to review
| Zola uses the directory structure to determine the site structure. | ||
| Each child directory in the `content` directory represents a [section](@/documentation/content/section.md) | ||
| that contains [pages](@/documentation/content/page.md) (your `.md` files). | ||
| Zola determines your site's structure from its directories. Each child folder in the `content` directory represents a separate [section](@/documentation/content/section.md)[^1]that contains [pages](@/documentation/content/page.md) (your `.md` files). |
Collaborator
There was a problem hiding this comment.
What do you think of https://zola.discourse.group/t/proposal-deprecate-sections/1968 ?
| * `id`: the video id (mandatory) | ||
| * `playlist`: the playlist id (optional) | ||
| * `class`: a class to add to the `<div>` surrounding the iframe | ||
| * `autoplay`: when set to "true", the video autoplays on load |
Collaborator
There was a problem hiding this comment.
Can we revert the - -> * changes? It's the same meaning and it causes unnecessary diff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussion issue: #2426
This PR aims to fix some tonal and guidance inconsistencies within the Zola docs. For now, I won't make any sweeping changes, as
tera2has progressed quite a lot!I'd be happy to focus on particular pages if anyone has any suggestions! :)