Skip to content

fix(ci): normalize path separators in blast radius summaries#82

Merged
haasonsaas merged 2 commits intomainfrom
fix/blast-radius-windows-path-separators
Mar 15, 2026
Merged

fix(ci): normalize path separators in blast radius summaries#82
haasonsaas merged 2 commits intomainfrom
fix/blast-radius-windows-path-separators

Conversation

@haasonsaas
Copy link
Collaborator

Summary

  • path.display() uses native separators, producing src\a.rs on Windows instead of src/a.rs
  • The applies_blast_radius_summary_for_many_dependents test asserts on forward-slash paths, so it fails on windows-latest
  • Fix: normalize backslashes to forward slashes in format_blast_radius_summary, since these paths are rendered in web UI review comments

Test plan

  • CI passes on all platforms (ubuntu, macos, windows)

🤖 Generated with Claude Code

path.display() uses native separators, producing backslashes on Windows.
Since these paths appear in review comments (web UI), normalize to
forward slashes so the output is consistent across platforms.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@cursor
Copy link

cursor bot commented Mar 15, 2026

PR Summary

Low Risk
Low risk: a small, presentation-only change that normalizes path formatting in generated review comments and adds a targeted unit test to prevent Windows-only failures.

Overview
Normalizes dependent file paths in blast radius review summaries by converting \\ to / when rendering PathBuf values, ensuring consistent output across platforms.

Adds a unit test (format_blast_radius_summary_normalizes_backslash_paths) to verify summaries never contain backslashes and remain stable on Windows CI.

Written by Cursor Bugbot for commit 8912a90. This will update automatically on new commits. Configure here.

Directly tests format_blast_radius_summary with Windows-style backslash
paths to verify they are normalized to forward slashes.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@haasonsaas haasonsaas merged commit 2030d5c into main Mar 15, 2026
14 of 15 checks passed
@haasonsaas haasonsaas deleted the fix/blast-radius-windows-path-separators branch March 15, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant