Conversation
- Add workspace and repo fields to wrapper struct - Add SetWorkspace() function to configure workspace - Use workspace when available to avoid account scope requirement - Fix fetchReposWithPagination to check for configured workspace - Update test files to use new wrapper struct format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances Bitbucket SCM client support for workspace- and repository-scoped credentials, making it easier to use repo-level tokens without requiring account-wide permissions. The main changes include extending the Bitbucket client to store workspace and repository information, adding a setter for these fields, and updating repository fetching logic and tests accordingly.
Bitbucket Client Enhancements:
wrapperstruct now includesworkspaceandrepofields to store workspace and repository names, enabling support for workspace- or repo-scoped tokens. (scm/driver/bitbucket/bitbucket.go)SetWorkspacefunction to allow setting the workspace and repo on the Bitbucket client, facilitating the use of workspace-specific API endpoints. (scm/driver/bitbucket/bitbucket.go)Repository Fetching Logic:
fetchReposWithPaginationto use the configured workspace directly if set, avoiding unnecessary API calls and supporting repo-scoped tokens. (scm/driver/bitbucket/util.go)Test Updates:
wrapperstruct with the newworkspaceandrepofields for consistency and to ensure tests reflect the new structure. (scm/driver/bitbucket/util_helpers_test.go,scm/driver/bitbucket/util_test.go) [1] [2] [3] [4] [5] [6]