Fix CVE-2025-67125: prevent signed counter overflow in LeafPattern::match#168
Open
thesmartshadow wants to merge 1 commit intodocopt:masterfrom
Open
Fix CVE-2025-67125: prevent signed counter overflow in LeafPattern::match#168thesmartshadow wants to merge 1 commit intodocopt:masterfrom
thesmartshadow wants to merge 1 commit intodocopt:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a signed integer overflow in
LeafPattern::matchwhen merging repeated option occurrences.What was happening
The previous implementation performed an unchecked signed addition when combining a newly matched occurrence with an already collected counter value.
In practice, if the existing counter reached
LONG_MAX, the next occurrence would trigger signed overflow (LONG_MAX + 1), which could lead to wrapped or otherwise invalid counter semantics.What this change does
Why this matters
This keeps the counter logic stable and predictable, especially for applications that rely on occurrence counts for limits, toggles, or other decision-making logic.
Notes