fix: remove config file path from login page#7709
Open
karesansui-u wants to merge 1 commit intocoder:mainfrom
Open
fix: remove config file path from login page#7709karesansui-u wants to merge 1 commit intocoder:mainfrom
karesansui-u wants to merge 1 commit intocoder:mainfrom
Conversation
The login page displayed the full config file path (e.g. /home/username/.config/code-server/config.yaml), which exposes the username and system layout to anyone who can see the page. The path is already printed in the CLI output when starting code-server, so showing it on the login page is unnecessary. Fixes coder#7643
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7643
The login page displayed the full config file path (e.g.
/home/username/.config/code-server/config.yaml), exposing theusername and system layout to anyone who can see the page.
The path is already printed in the CLI output at startup, so
showing it on the login page is unnecessary. Removed the
{{configFile}}interpolation from all locale files.