refactor: extract shared dropFile script for attachFile dropzone support#5486
Merged
refactor: extract shared dropFile script for attachFile dropzone support#5486
Conversation
When the target element is not an <input type="file">, attachFile now falls back to dispatching synthetic drag-and-drop events (dragenter, dragover, drop) with a DataTransfer containing the file. This enables file uploads to dropzone libraries (Dropzone.js, react-dropzone, etc.). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
550015a to
a75abfd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/helper/scripts/dropFile.jsdropFilefunction instead of copy-pasting the browser-side codeTest plan
attachFiletests pass for Playwright (2/2)attachFiletests pass for Puppeteer (2/2)🤖 Generated with Claude Code