feat: add org setting to enable AI agent config collector#2878
Open
jiparis wants to merge 5 commits intochainloop-dev:mainfrom
Open
feat: add org setting to enable AI agent config collector#2878jiparis wants to merge 5 commits intochainloop-dev:mainfrom
jiparis wants to merge 5 commits intochainloop-dev:mainfrom
Conversation
Add a new organization-level boolean setting `enable_ai_agent_collector` that automatically activates the AI agent config collector during attestation init without requiring the `--collectors aiconfig` CLI flag. Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
There was a problem hiding this comment.
1 issue found across 40 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="app/controlplane/pkg/biz/organization.go">
<violation number="1" location="app/controlplane/pkg/biz/organization.go:199">
P2: The update API is becoming an opaque positional-argument call with multiple optional pointer flags; adding another bool increases the risk of argument-order bugs. Prefer a single `UpdateOptions`/params struct.
(Based on your team's feedback about designing APIs to avoid opaque call patterns.) [FEEDBACK_USED]</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Replace 8 positional parameters on OrganizationRepo.Update and OrganizationUseCase.Update with an OrganizationUpdateOpts struct for better readability and extensibility. Also regenerate CLI docs and add CLI documentation instruction to CLAUDE.md. Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
There was a problem hiding this comment.
1 issue found across 9 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="app/controlplane/pkg/biz/organization.go">
<violation number="1" location="app/controlplane/pkg/biz/organization.go:231">
P2: Guard against nil update options before calling the repository; otherwise `Update(..., nil)` can panic via nil-pointer dereference.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enable_ai_agent_collectororg setting that auto-enables the AI agent config collector duringattestation initchainloop org update --enable-ai-agent-collectorCLI flag and the gRPC/HTTP APIOrganizationRepo.UpdateandOrganizationUseCase.Updateto use anOrganizationUpdateOptsstruct instead of 8 positional parametersCloses #2879