feat: Add SQLite support for domain audit#7821
feat: Add SQLite support for domain audit#7821joannalauu wants to merge 2 commits intocadence-workflow:masterfrom
Conversation
Signed-off-by: Joanna Lau <118241363+joannalauu@users.noreply.github.com>
19c5a54 to
543cf05
Compare
bd0663c to
9c0c348
Compare
9c0c348 to
97567b5
Compare
Signed-off-by: Joanna Lau <118241363+joannalauu@users.noreply.github.com>
97567b5 to
f22c930
Compare
Code Review ✅ Approved 2 resolved / 2 findingsAdds SQLite support for domain audit with fixes for DATETIME precision consistency and migration safety. No issues found. ✅ 2 resolved✅ Bug: DATETIME missing (6) precision — inconsistent with schema
✅ Bug: Mutating already-merged v0.7 migration breaks existing deployments
OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
What changed?
Added SQLite support for DomainAudit.
Fixes: #7604
Why?
DomainAudit allows all modifications made to a domain (e.g failovers) to be stored and retrieved. This has previously only been supported by NoSQL databases (Cassandra, MongoDB, DynamoDB), MySQL and PostgreSQL. SQLite support for DomainAudit is now added.
How did you test it?
TestSQLiteDomainAuditPersistenceon github actionsPotential risks
Release notes
SQLite support is added for domain audit
Documentation Changes
N/A
Detailed Description
Added SQLite support for DomainAudit.
Impact Analysis
Testing Plan
TestSQLiteDomainAuditPersistenceon github actionsRollout Plan
Reviewer Validation
PR Description Quality (check these before reviewing code):
go testinvocation)