Added support for KVM teamd devices to LibvirtComputingResource.java#966
Merged
asfgit merged 1 commit intoapache:masterfrom Oct 25, 2015
Merged
Conversation
… This will allow users to utilze teamd nic teaming devices named team*.
Contributor
Contributor
|
Agreed with @remibergsma, but the code-wise this is a LGTM. One PR which includes #812 as well would be nice. |
Contributor
Author
|
I'll take a look at #812 and see about combining them into this PR. |
Contributor
|
@dmabry I am already writng a combination. please review when done |
Contributor
Author
|
@DaanHoogland Sounds good. I'll hold off. Thanks for the help. |
asfgit
pushed a commit
that referenced
this pull request
Oct 25, 2015
CLOUDSTACK-8838 Interface pattern checkthsi closes #812 and #966 as well * pr/973: unit test for interface patterns in libvirt compute resource Added support for KVM teamd devices to LibvirtComputingResource.java. This will allow users to utilze teamd nic teaming devices named team*. CLOUDSTACK-8838: Allow ensX enoX enpX enxX format for nics in CentOS 7 Signed-off-by: Remi Bergsma <github@remi.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow KVM users to utilize teamd nic teaming devices named team*.