Update SystemVM scripts from python2 to python3#3730
Update SystemVM scripts from python2 to python3#3730GabrielBrascher wants to merge 6 commits intoapache:masterfrom
Conversation
7f40fbb to
de8d94f
Compare
|
some pylint errors in travis job 1, mostly requiring extra blank lines at places @GabrielBrascher . |
d4d0458 to
199efd7
Compare
| * HighAvailabilityManager checks to make sure the VMs are running fine. | ||
| */ | ||
| public interface HighAvailabilityManager extends Manager { | ||
|
|
There was a problem hiding this comment.
@GabrielBrascher why do I see java changes in this PR?
There was a problem hiding this comment.
My bad @DaanHoogland, I was debugging this and did commit by mistake, will soon be removed soon.
aaa994b to
4356562
Compare
|
@GabrielBrascher can you give an indication on this. as we are out of time for python2 now? |
|
@DaanHoogland it still needs some work and testing, therefore, we can wait a bit for reviewing it. |
4356562 to
447cd3f
Compare
|
@GabrielBrascher I see pylint errors again in travis job 1, can you have a look? |
99c2cad to
6259183
Compare
6259183 to
3195b6f
Compare
|
@GabrielBrascher @wido @rhtyd @weizhouapache @PaulAngus python3 work in general has been neglected for a while. Are we still going to push it for 4.15? |
|
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
@DaanHoogland I have been able to run some tests on the Advanced network with security groups, and a few tests on the basic network. But it still lacking some tests on advanced networks with VPC, etc. With that said, I think that we will need a couple more months and also more review/test. |
|
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2222 |
|
@GabrielBrascher that would mean moving to the next milestone! |
|
@DaanHoogland correct! I migrated it to 4.16 so we don't wait longer to release 4.15. |
|
@blueorangutan package |
|
@GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2673 |
60d0ca5 to
65bb394
Compare
|
@GabrielBrascher can we close this? |
|
@DaanHoogland sure! I will close this one, if necessary we can always re-open it. |
|
PR closed in favor of #4727. |
Description
Considering that Python 2.7 will not be maintained in 2020 (will be retired on 1st January 2020) next VR template should have Python3 installed to support python3 scripts; additionally, VR's Python2 codebase should be migrated to Python3.
This PR covers partially issue Python 3 compatibility #3195.
Types of changes