router: Fixes #2719 program VR nics by device id order for VPC

[yadvr]

This fixes #2719 where private gateway IP might be incorrectly
programmed on a guest network nic. The VR would now check ipassoc
requests by mac addresses than provided nic/device id in case they are
wrong.

The root cause is that the device id information is lost when aggregated
commands are created upon starting of a new VPC VR, without the correct
device id in ip_associations json it mis-programs the VR.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

GitHub Issue/PRs

#2719

How Has This Been Tested?

Deploy VPC
Deploy a guest VM on a tier
Add a private gateway
Restart the VPC with cleanup=true
The private gateway should be on correct dev idx (previously both guest network and private gw would be on eth2, eth3 will not have any ip)

/cc @PaulAngus @borisstoyanov

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2336

[borisstoyanov]

@blueorangutan test

[blueorangutan]

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[yadvr]

@PaulAngus if you've time this week, can you review this as well in your environment where you were able to see the bug?

[PaulAngus]

LTGM based on specific functionality fix test.

just need to wait for overall smoke tests.

test_01_vpc_privategw_acl (tests.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: test_01_vpc_privategw_acl | Status : SUCCESS ===
ok
test_02_vpc_privategw_static_routes (tests.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: test_02_vpc_privategw_static_routes | Status : SUCCESS ===
ok
test_03_vpc_privategw_restart_vpc_cleanup (tests.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: test_03_vpc_privategw_restart_vpc_cleanup | Status : SUCCESS ===
ok
test_04_rvpc_privategw_static_routes (tests.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: test_04_rvpc_privategw_static_routes | Status : SUCCESS ===
ok

---

Ran 4 tests in 687.214s

OK

[yadvr]

Thanks @PaulAngus for reviewing and testing.

[blueorangutan]

Trillian test result (tid-3066)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 23259 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2888-t3066-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 65 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_05_rvpc_multi_tiers	Failure	308.31	test_vpc_redundant.py
test_05_rvpc_multi_tiers	Error	331.36	test_vpc_redundant.py
test_hostha_enable_ha_when_host_in_maintenance	Error	5.63	test_hostha_kvm.py

[borisstoyanov]

LGTM

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2338