Skip to content

feat(schema): upgrade ACP schema from v0.10.8 to v0.11.2 #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nemtecl wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(schema): upgrade ACP schema from v0.10.8 to v0.11.2 #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions examples/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
EnvVariable,
ImageContentBlock,
Implementation,
KillTerminalCommandResponse,
KillTerminalResponse,
PermissionOption,
ReadTextFileResponse,
ReleaseTerminalResponse,
Expand Down Expand Up @@ -86,9 +86,7 @@ async def wait_for_terminal_exit(
) -> WaitForTerminalExitResponse:
raise RequestError.method_not_found("terminal/wait_for_exit")

async def kill_terminal(
self, session_id: str, terminal_id: str, **kwargs: Any
) -> KillTerminalCommandResponse | None:
async def kill_terminal(self, session_id: str, terminal_id: str, **kwargs: Any) -> KillTerminalResponse | None:
raise RequestError.method_not_found("terminal/kill")

async def session_update(
Expand Down
12 changes: 5 additions & 7 deletions examples/gemini.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@
EmbeddedResourceContentBlock,
EnvVariable,
FileEditToolCallContent,
FileSystemCapability,
KillTerminalCommandResponse,
FileSystemCapabilities,
KillTerminalResponse,
PermissionOption,
ReadTextFileResponse,
ReleaseTerminalResponse,
Expand Down Expand Up @@ -183,11 +183,9 @@ async def wait_for_terminal_exit(
print(f"[Client] waitForTerminalExit: {session_id} {terminal_id}")
return WaitForTerminalExitResponse()

async def kill_terminal(
self, session_id: str, terminal_id: str, **kwargs: Any
) -> KillTerminalCommandResponse | None:
async def kill_terminal(self, session_id: str, terminal_id: str, **kwargs: Any) -> KillTerminalResponse | None:
print(f"[Client] killTerminal: {session_id} {terminal_id}")
return KillTerminalCommandResponse()
return KillTerminalResponse()


def _pick_preferred_option(options: Iterable[PermissionOption]) -> PermissionOption | None:
Expand Down Expand Up @@ -320,7 +318,7 @@ async def run(argv: list[str]) -> int: # noqa: C901
init_resp = await conn.initialize(
protocol_version=PROTOCOL_VERSION,
client_capabilities=ClientCapabilities(
fs=FileSystemCapability(read_text_file=True, write_text_file=True),
fs=FileSystemCapabilities(read_text_file=True, write_text_file=True),
terminal=True,
),
)
Expand Down
2 changes: 1 addition & 1 deletion schema/VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
refs/tags/v0.10.8
refs/tags/v0.11.2
1 change: 1 addition & 0 deletions schema/meta.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"authenticate": "authenticate",
"initialize": "initialize",
"session_cancel": "session/cancel",
"session_close": "session/close",
"session_fork": "session/fork",
"session_list": "session/list",
"session_load": "session/load",
Expand Down
Loading
Loading