Open
Conversation
…especially vars renaming 2. evaluate_rag - added q_a file as input 3. ran all notebook
added original memorag results
rearranged some parts
1. q_a for Wealth of nations 2. q_a for Wealth of nations for testing (only 2 questions) 3. generated answers for evaluation use
Added markdown cells and some more documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Well, at some point I split to another branch because I had a technical problem with the notebook (long story).
In the old branch (MeomRAG) the last commit is from the 9th of March.
In the new branch (MemoRAG_zvika. I don't remember why I named it this way. Maybe I wanted to ask for review from my friend Zvika, but even if I did, it never really happened) there are more commits, some of which include the removal of redundant drafts etc.
There are also some additions and changes in the code, mostly (but not only) in the comparison part.
There are still some files to be removed and of course the rearrangement of code you asked for (split to cells, add more markdown cells), but I thought I'd open this PR just so it's aligned with the updates.