Choose email address for merge commit on Web UI when merging #27375
Replies: 2 comments
-
|
Worse: if you are enforcing merge rules to ensure use of the correct (company) email, then this rewrite will break those rules and prevent merging! |
Beta Was this translation helpful? Give feedback.
-
|
Still not fixed after more than 3 years. If I check "Keep my email addresses private" github inserts a weird email address. I used this in the past. But this is not a valid address and is not accepted everywhere. So I added this second address. I configured this address on my PC as the default author email. Unfortunately github chooses my private email address as commit email if I let it create an initial commit with a readme. It did so without my consent. Fortunately the repo is still private and I was able to rewrite history and force push the changes. But this is a major privacy risk. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Currently, when merging a PR, the merge commit associated with that PR is the automatically set to the user's primary email address, or the default noreply email address if their emails are set to private. However, for those not wishing to use Github in different contexts, this may be difficult. For instance, if a user works for an organization and has an organization repo, then their merge commit email address should be their company email address, and should not expose their private or personal email address at commit time.
There should also be a difference between default primary emails and the email address used for commits. For instance, a user might have a primary email that should be used for administration of their GitHub account, notifications, etc, but not want that email to be associated with commits.
All in all, what I would like here is a level of granularity in how GitHub handles email addresses. Being able to set the email used for commits on a per-repository basis would be ideal, but in the meantime, I think the simplest, easiest solution is just to offer the user a select box asking which email to use for the commit when a merge happens.
Beta Was this translation helpful? Give feedback.
All reactions