feat: add more informative error when fetching latest stable fails#644
Merged
aduh95 merged 11 commits intonodejs:mainfrom Feb 28, 2025
Merged
feat: add more informative error when fetching latest stable fails#644aduh95 merged 11 commits intonodejs:mainfrom
aduh95 merged 11 commits intonodejs:mainfrom
Conversation
aduh95
commented
Feb 20, 2025
Contributor
Author
|
Would like some review on the wording here please /cc @nodejs/corepack |
arcanis
reviewed
Feb 28, 2025
Contributor
arcanis
left a comment
There was a problem hiding this comment.
I'd suggest to use UsageError, since printing a stacktrace in those errors is useless and potentially confusing (feels like an internal error rather than a user / system error).
Co-authored-by: Maël Nison <nison.mael@gmail.com>
aduh95
commented
Feb 28, 2025
Co-authored-by: Maël Nison <nison.mael@gmail.com>
aduh95
commented
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.